From 1bd540b1cdd65adc2ea368c62afabeae6e715e9b Mon Sep 17 00:00:00 2001 From: Wally Hackenslacker Date: Mon, 16 Mar 2026 21:04:00 -0400 Subject: [PATCH] test: enforce card detail activities order ownership in repository --- .../app/carddetail/CardDetailViewModelTest.kt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/src/test/java/space/hackenslacker/kanbn4droid/app/carddetail/CardDetailViewModelTest.kt b/app/src/test/java/space/hackenslacker/kanbn4droid/app/carddetail/CardDetailViewModelTest.kt index db0e8fb..22ea69c 100644 --- a/app/src/test/java/space/hackenslacker/kanbn4droid/app/carddetail/CardDetailViewModelTest.kt +++ b/app/src/test/java/space/hackenslacker/kanbn4droid/app/carddetail/CardDetailViewModelTest.kt @@ -54,7 +54,8 @@ class CardDetailViewModelTest { assertEquals("Description", state.description) assertEquals(LocalDate.of(2026, 3, 16), state.dueDate) assertEquals(listOf("tag-1", "tag-2"), state.tags.map { it.id }) - assertEquals(listOf("a-new", "a-mid", "a-old"), state.activities.map { it.id }) + assertEquals(listOf("a-mid", "a-new", "a-old"), state.activities.map { it.id }) + assertEquals(listOf(2L, 3L, 1L), state.activities.map { it.createdAtEpochMillis }) assertNull(state.loadErrorMessage) } @@ -243,7 +244,7 @@ class CardDetailViewModelTest { assertEquals("", viewModel.uiState.value.commentDraft) assertEquals(1, repository.addCommentCalls) assertEquals(2, repository.listActivitiesCalls) - assertEquals(listOf("a-new", "a-mid", "a-old"), viewModel.uiState.value.activities.map { it.id }) + assertEquals(listOf("a-mid", "a-new", "a-old"), viewModel.uiState.value.activities.map { it.id }) assertTrue(eventDeferred.await() is CardDetailUiEvent.ShowSnackbar) } @@ -288,7 +289,7 @@ class CardDetailViewModelTest { advanceUntilIdle() assertNull(viewModel.uiState.value.activitiesErrorMessage) - assertEquals(listOf("a-new", "a-mid", "a-old"), viewModel.uiState.value.activities.map { it.id }) + assertEquals(listOf("a-mid", "a-new", "a-old"), viewModel.uiState.value.activities.map { it.id }) } @Test @@ -440,8 +441,8 @@ class CardDetailViewModelTest { fun sampleActivitiesShuffled(): List { return listOf( - CardActivity(id = "a-new", type = "comment", text = "new", createdAtEpochMillis = 3L), CardActivity(id = "a-mid", type = "comment", text = "mid", createdAtEpochMillis = 2L), + CardActivity(id = "a-new", type = "comment", text = "new", createdAtEpochMillis = 3L), CardActivity(id = "a-old", type = "comment", text = "old", createdAtEpochMillis = 1L), ) }