diff --git a/AGENTS.md b/AGENTS.md index 1809c0e..604415f 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -23,7 +23,6 @@ Kanbn4Droid is an unofficial app to connect to and manipulate data stored in sel - Compile/target SDK: API 35. - Baseline tests: - JVM unit tests for auth URL normalization and auth error mapping in `app/src/test/`. - - JVM unit tests for board detail parsing and board/list/card API request mapping in `app/src/test/space/hackenslacker/kanbn4droid/app/auth/HttpKanbnApiClientBoardDetailParsingTest.kt`. - JVM unit tests for boards repository and boards view model in `app/src/test/space/hackenslacker/kanbn4droid/app/boards/`. - Instrumentation tests for login and boards flows in `app/src/androidTest/`. diff --git a/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardsFlowTest.kt b/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardsFlowTest.kt index 55d51eb..fbd6c8e 100644 --- a/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardsFlowTest.kt +++ b/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardsFlowTest.kt @@ -24,7 +24,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore import space.hackenslacker.kanbn4droid.app.auth.AuthResult import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient import space.hackenslacker.kanbn4droid.app.auth.SessionStore -import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail import space.hackenslacker.kanbn4droid.app.boards.BoardSummary import space.hackenslacker.kanbn4droid.app.boards.BoardTemplate import space.hackenslacker.kanbn4droid.app.boards.BoardsApiResult @@ -200,31 +199,5 @@ class BoardsFlowTest { boards.removeAll { it.id == boardId } return BoardsApiResult.Success(Unit) } - - override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun renameList( - baseUrl: String, - apiKey: String, - listId: String, - newTitle: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun moveCard( - baseUrl: String, - apiKey: String, - cardId: String, - targetListId: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } } } diff --git a/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/LoginFlowTest.kt b/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/LoginFlowTest.kt index 57a8e93..67350a9 100644 --- a/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/LoginFlowTest.kt +++ b/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/LoginFlowTest.kt @@ -22,8 +22,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore import space.hackenslacker.kanbn4droid.app.auth.AuthResult import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient import space.hackenslacker.kanbn4droid.app.auth.SessionStore -import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail -import space.hackenslacker.kanbn4droid.app.boards.BoardsApiResult @RunWith(AndroidJUnit4::class) class LoginFlowTest { @@ -202,31 +200,5 @@ class LoginFlowTest { private val result: AuthResult, ) : KanbnApiClient { override suspend fun healthCheck(baseUrl: String, apiKey: String): AuthResult = result - - override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun renameList( - baseUrl: String, - apiKey: String, - listId: String, - newTitle: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun moveCard( - baseUrl: String, - apiKey: String, - cardId: String, - targetListId: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } } } diff --git a/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsRepositoryTest.kt b/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsRepositoryTest.kt index 7fbe893..2aabe86 100644 --- a/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsRepositoryTest.kt +++ b/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsRepositoryTest.kt @@ -8,7 +8,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore import space.hackenslacker.kanbn4droid.app.auth.AuthResult import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient import space.hackenslacker.kanbn4droid.app.auth.SessionStore -import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail class BoardsRepositoryTest { @@ -251,31 +250,5 @@ class BoardsRepositoryTest { lastDeletedId = boardId return deleteBoardResult } - - override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun renameList( - baseUrl: String, - apiKey: String, - listId: String, - newTitle: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun moveCard( - baseUrl: String, - apiKey: String, - cardId: String, - targetListId: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } } } diff --git a/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsViewModelTest.kt b/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsViewModelTest.kt index 799c73c..a5d901e 100644 --- a/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsViewModelTest.kt +++ b/app/src/test/java/space/hackenslacker/kanbn4droid/app/boards/BoardsViewModelTest.kt @@ -19,7 +19,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore import space.hackenslacker.kanbn4droid.app.auth.AuthResult import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient import space.hackenslacker.kanbn4droid.app.auth.SessionStore -import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail @OptIn(ExperimentalCoroutinesApi::class) class BoardsViewModelTest { @@ -195,31 +194,5 @@ class BoardsViewModelTest { lastDeletedId = boardId return deleteBoardResult } - - override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun renameList( - baseUrl: String, - apiKey: String, - listId: String, - newTitle: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun moveCard( - baseUrl: String, - apiKey: String, - cardId: String, - targetListId: String, - ): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } - - override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult { - return BoardsApiResult.Failure("Not used in this test") - } } }