From a7af727752f78de3ee78dcd1778db01c2b20a8e7 Mon Sep 17 00:00:00 2001
From: Wally Hackenslacker <mastor89@protonmail.com>
Date: Mon, 16 Mar 2026 01:42:14 -0400
Subject: [PATCH] fix: use string resources for card placeholder navigation
 labels

---
 .../hackenslacker/kanbn4droid/app/BoardDetailFlowTest.kt     | 5 ++++-
 .../kanbn4droid/app/CardDetailPlaceholderActivity.kt         | 2 +-
 .../kanbn4droid/app/boarddetail/BoardDetailActivity.kt       | 2 +-
 app/src/main/res/layout/activity_card_detail_placeholder.xml | 2 +-
 app/src/main/res/values/strings.xml                          | 3 +++
 5 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardDetailFlowTest.kt b/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardDetailFlowTest.kt
index f73ad9b..318fb9a 100644
--- a/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardDetailFlowTest.kt
+++ b/app/src/androidTest/java/space/hackenslacker/kanbn4droid/app/BoardDetailFlowTest.kt
@@ -6,6 +6,7 @@ import android.view.inputmethod.EditorInfo
 import android.view.View
 import android.widget.TextView
 import androidx.test.core.app.ActivityScenario
+import androidx.test.core.app.ApplicationProvider
 import androidx.test.espresso.Espresso.onView
 import androidx.test.espresso.action.ViewActions.click
 import androidx.test.espresso.action.ViewActions.longClick
@@ -267,10 +268,12 @@ class BoardDetailFlowTest {
         launchBoardDetail()
 
         onView(withId(R.id.cardItemRoot)).perform(click())
+        val expectedFallback = ApplicationProvider.getApplicationContext<android.content.Context>()
+            .getString(R.string.card_detail_placeholder_fallback_title)
 
         Intents.intended(hasComponent(CardDetailPlaceholderActivity::class.java.name))
         Intents.intended(hasExtra(CardDetailPlaceholderActivity.EXTRA_CARD_ID, "card-1"))
-        Intents.intended(hasExtra(CardDetailPlaceholderActivity.EXTRA_CARD_TITLE, "Card"))
+        Intents.intended(hasExtra(CardDetailPlaceholderActivity.EXTRA_CARD_TITLE, expectedFallback))
     }
 
     private fun launchBoardDetail(): ActivityScenario<BoardDetailActivity> {
diff --git a/app/src/main/java/space/hackenslacker/kanbn4droid/app/CardDetailPlaceholderActivity.kt b/app/src/main/java/space/hackenslacker/kanbn4droid/app/CardDetailPlaceholderActivity.kt
index ba4db7b..4472643 100644
--- a/app/src/main/java/space/hackenslacker/kanbn4droid/app/CardDetailPlaceholderActivity.kt
+++ b/app/src/main/java/space/hackenslacker/kanbn4droid/app/CardDetailPlaceholderActivity.kt
@@ -14,7 +14,7 @@ class CardDetailPlaceholderActivity : AppCompatActivity() {
         val cardTitle = intent.getStringExtra(EXTRA_CARD_TITLE).orEmpty()
 
         val titleView: TextView = findViewById(R.id.cardDetailPlaceholderTitle)
-        titleView.text = "$cardTitle\n(id: $cardId)"
+        titleView.text = getString(R.string.card_detail_placeholder_title, cardTitle, cardId)
     }
 
     companion object {
diff --git a/app/src/main/java/space/hackenslacker/kanbn4droid/app/boarddetail/BoardDetailActivity.kt b/app/src/main/java/space/hackenslacker/kanbn4droid/app/boarddetail/BoardDetailActivity.kt
index d9ed9ab..4185b99 100644
--- a/app/src/main/java/space/hackenslacker/kanbn4droid/app/boarddetail/BoardDetailActivity.kt
+++ b/app/src/main/java/space/hackenslacker/kanbn4droid/app/boarddetail/BoardDetailActivity.kt
@@ -168,7 +168,7 @@ class BoardDetailActivity : AppCompatActivity() {
                             ?.title
                             .orEmpty()
                             .trim()
-                            .ifBlank { "Card" }
+                            .ifBlank { getString(R.string.card_detail_placeholder_fallback_title) }
                         startActivity(
                             Intent(this@BoardDetailActivity, CardDetailPlaceholderActivity::class.java)
                                 .putExtra(CardDetailPlaceholderActivity.EXTRA_CARD_ID, event.cardId)
diff --git a/app/src/main/res/layout/activity_card_detail_placeholder.xml b/app/src/main/res/layout/activity_card_detail_placeholder.xml
index 7189ea4..9005c6a 100644
--- a/app/src/main/res/layout/activity_card_detail_placeholder.xml
+++ b/app/src/main/res/layout/activity_card_detail_placeholder.xml
@@ -21,7 +21,7 @@
         android:layout_height="wrap_content"
         android:layout_marginTop="16dp"
         android:gravity="center"
-        android:text="@string/board_detail_card_detail_coming_soon"
+        android:text="@string/card_detail_placeholder_subtitle"
         android:textAppearance="@style/TextAppearance.MaterialComponents.Body1"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 1c0679b..6d1956a 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -44,4 +44,7 @@
     <string name="delete_cards_confirmation">Delete selected cards?</string>
     <string name="delete_cards_second_confirmation">Are you sure you want to permanently delete the selected cards?</string>
     <string name="board_detail_card_detail_coming_soon">Card detail view is coming soon.</string>
+    <string name="card_detail_placeholder_title">%1$s\n(id: %2$s)</string>
+    <string name="card_detail_placeholder_fallback_title">Card</string>
+    <string name="card_detail_placeholder_subtitle">Card detail view is coming soon.</string>
 </resources>