chore: remove out-of-scope changes from task 2
This commit is contained in:
@@ -23,7 +23,6 @@ Kanbn4Droid is an unofficial app to connect to and manipulate data stored in sel
|
|||||||
- Compile/target SDK: API 35.
|
- Compile/target SDK: API 35.
|
||||||
- Baseline tests:
|
- Baseline tests:
|
||||||
- JVM unit tests for auth URL normalization and auth error mapping in `app/src/test/`.
|
- JVM unit tests for auth URL normalization and auth error mapping in `app/src/test/`.
|
||||||
- JVM unit tests for board detail parsing and board/list/card API request mapping in `app/src/test/space/hackenslacker/kanbn4droid/app/auth/HttpKanbnApiClientBoardDetailParsingTest.kt`.
|
|
||||||
- JVM unit tests for boards repository and boards view model in `app/src/test/space/hackenslacker/kanbn4droid/app/boards/`.
|
- JVM unit tests for boards repository and boards view model in `app/src/test/space/hackenslacker/kanbn4droid/app/boards/`.
|
||||||
- Instrumentation tests for login and boards flows in `app/src/androidTest/`.
|
- Instrumentation tests for login and boards flows in `app/src/androidTest/`.
|
||||||
|
|
||||||
|
|||||||
@@ -24,7 +24,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore
|
|||||||
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
||||||
import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail
|
|
||||||
import space.hackenslacker.kanbn4droid.app.boards.BoardSummary
|
import space.hackenslacker.kanbn4droid.app.boards.BoardSummary
|
||||||
import space.hackenslacker.kanbn4droid.app.boards.BoardTemplate
|
import space.hackenslacker.kanbn4droid.app.boards.BoardTemplate
|
||||||
import space.hackenslacker.kanbn4droid.app.boards.BoardsApiResult
|
import space.hackenslacker.kanbn4droid.app.boards.BoardsApiResult
|
||||||
@@ -200,31 +199,5 @@ class BoardsFlowTest {
|
|||||||
boards.removeAll { it.id == boardId }
|
boards.removeAll { it.id == boardId }
|
||||||
return BoardsApiResult.Success(Unit)
|
return BoardsApiResult.Success(Unit)
|
||||||
}
|
}
|
||||||
|
|
||||||
override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult<BoardDetail> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun renameList(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
listId: String,
|
|
||||||
newTitle: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun moveCard(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
cardId: String,
|
|
||||||
targetListId: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -22,8 +22,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore
|
|||||||
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
||||||
import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail
|
|
||||||
import space.hackenslacker.kanbn4droid.app.boards.BoardsApiResult
|
|
||||||
|
|
||||||
@RunWith(AndroidJUnit4::class)
|
@RunWith(AndroidJUnit4::class)
|
||||||
class LoginFlowTest {
|
class LoginFlowTest {
|
||||||
@@ -202,31 +200,5 @@ class LoginFlowTest {
|
|||||||
private val result: AuthResult,
|
private val result: AuthResult,
|
||||||
) : KanbnApiClient {
|
) : KanbnApiClient {
|
||||||
override suspend fun healthCheck(baseUrl: String, apiKey: String): AuthResult = result
|
override suspend fun healthCheck(baseUrl: String, apiKey: String): AuthResult = result
|
||||||
|
|
||||||
override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult<BoardDetail> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun renameList(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
listId: String,
|
|
||||||
newTitle: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun moveCard(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
cardId: String,
|
|
||||||
targetListId: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -8,7 +8,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore
|
|||||||
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
||||||
import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail
|
|
||||||
|
|
||||||
class BoardsRepositoryTest {
|
class BoardsRepositoryTest {
|
||||||
|
|
||||||
@@ -251,31 +250,5 @@ class BoardsRepositoryTest {
|
|||||||
lastDeletedId = boardId
|
lastDeletedId = boardId
|
||||||
return deleteBoardResult
|
return deleteBoardResult
|
||||||
}
|
}
|
||||||
|
|
||||||
override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult<BoardDetail> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun renameList(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
listId: String,
|
|
||||||
newTitle: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun moveCard(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
cardId: String,
|
|
||||||
targetListId: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -19,7 +19,6 @@ import space.hackenslacker.kanbn4droid.app.auth.ApiKeyStore
|
|||||||
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
import space.hackenslacker.kanbn4droid.app.auth.AuthResult
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
import space.hackenslacker.kanbn4droid.app.auth.KanbnApiClient
|
||||||
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
import space.hackenslacker.kanbn4droid.app.auth.SessionStore
|
||||||
import space.hackenslacker.kanbn4droid.app.boarddetail.BoardDetail
|
|
||||||
|
|
||||||
@OptIn(ExperimentalCoroutinesApi::class)
|
@OptIn(ExperimentalCoroutinesApi::class)
|
||||||
class BoardsViewModelTest {
|
class BoardsViewModelTest {
|
||||||
@@ -195,31 +194,5 @@ class BoardsViewModelTest {
|
|||||||
lastDeletedId = boardId
|
lastDeletedId = boardId
|
||||||
return deleteBoardResult
|
return deleteBoardResult
|
||||||
}
|
}
|
||||||
|
|
||||||
override suspend fun getBoardDetail(baseUrl: String, apiKey: String, boardId: String): BoardsApiResult<BoardDetail> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun renameList(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
listId: String,
|
|
||||||
newTitle: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun moveCard(
|
|
||||||
baseUrl: String,
|
|
||||||
apiKey: String,
|
|
||||||
cardId: String,
|
|
||||||
targetListId: String,
|
|
||||||
): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
|
|
||||||
override suspend fun deleteCard(baseUrl: String, apiKey: String, cardId: String): BoardsApiResult<Unit> {
|
|
||||||
return BoardsApiResult.Failure("Not used in this test")
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user