Removed control protocol implementation in favor of libnxtarcontrol.

README.md

@@ -1,4 +1,27 @@
-NxtAR-bot
-=========
+NxtAR: A generic software architecture for Augmented Reality based mobile robot control.
+========================================================================================
 
-Modulo 3 de mi trabajo especial de grado.
+Robot control module
+--------------------
+
+### Abstract ###
+
+NxtAR is a generic software architecture for the development of Augmented Reality games
+and applications centered around mobile robot control. This is a reference implementation
+with support for [LEGO Mindstorms NXT][1] mobile robots.
+
+### Module description ###
+
+The robot control module is a control application that receives control commands sent from the 
+[NxtAR-cam][2] module and executes concrete control instructions as supported by the [LejOS][3] firmware.
+
+### Module installation and usage. ###
+
+Upload the NxtAR-bot_XXXXXX.nxj file to the LEGO Mindstorms NXT robot and execute it. Then follow the
+on-screen instructions. More detailed usage instructions can be found in the [NxtAR Android backend module][4]
+documentation. The robot must have the LejOS firmware installed prior to loading the nxj file.
+
+ [1]: http://www.lego.com/en-us/mindstorms/?domainredir=mindstorms.lego.com
+ [2]: https://github.com/sagge-miky/NxtAR-cam
+ [3]: http://www.lejos.org/nxj.php
+ [4]: https://github.com/sagge-miky/NxtAR-android

src/ve/ucv/ciens/ccg/nxtarbot/NxtAR_bot.java

@@ -40,7 +40,7 @@ public class NxtAR_bot{
 	private static SensorReportThread sendThread;
 
 	/**
-	 * <p>Finishes the communication threads anc closes the Bluetooth data streams, 
+	 * <p>Finishes the communication threads and closes the Bluetooth data streams, 
 	 * then quits the application.</p>
 	 */
 	private static void quit(){
@@ -78,7 +78,7 @@ public class NxtAR_bot{
 
 		// Start the light sensor and calibrate it.
 		LightSensor lightSensor = new LightSensor(SensorPort.S1);
-		lightSensor.setFloodlight(false);
+		lightSensor.setFloodlight(true);
 
 		System.out.println("Point at dark\nand press ENTER");
 		Button.ENTER.waitForPress();
@@ -89,6 +89,7 @@ public class NxtAR_bot{
 		Button.ENTER.waitForPress();
 		lightSensor.calibrateHigh();
 		System.out.println("--/--");
+		System.out.println("Waiting for BT\nconnection");
 
 		// Connect with a Bluetooth device in raw mode. Then get the connection
 		// streams.
@@ -97,6 +98,7 @@ public class NxtAR_bot{
 		dataOutputStream = bluetoothConnection.openDataOutputStream();
 		dataInputStream = bluetoothConnection.openDataInputStream();
 
+		System.out.println("--/--");
 		System.out.println("Connected");
 
 		// Start the networking threads and wait for them to finish. 
@@ -118,19 +120,15 @@ public class NxtAR_bot{
 	 * <p>Force quit button listener.</p>
 	 */
 	private static class QuitButtonListener implements ButtonListener{
-		/**
-		 * Force quit.
-		 */
 		@Override
 		public void buttonPressed(Button b){
+			// Force quit.
+			System.out.println("--/--");
+			System.out.println("Quitting");
 			System.exit(0);
-			//quit();
 		}
 
-		/**
-		 * Do nothing.
-		 */
 		@Override
-		public void buttonReleased(Button b){ }
+		public void buttonReleased(Button b){ /* Ignore */ }
 	}
 }

src/ve/ucv/ciens/ccg/nxtarbot/protocol/MotorMasks.java

@@ -18,7 +18,8 @@ package ve.ucv.ciens.ccg.nxtarbot.protocol;
 /**
  * <p>Bit masks used to code/decode the control instructions sent by NxtAR-cam to
  * NxtAR-bot.</p>
- * <p>Expansions 1-3 are currently unused.</p>
+ *
+ * <p>Expansions 2-3 are currently unused.</p>
  */
 public abstract class MotorMasks {
 	public static final byte MOTOR_A     = (byte)0x01;
@@ -26,7 +27,7 @@ public abstract class MotorMasks {
 	public static final byte MOTOR_C     = (byte)0x04;
 	public static final byte DIRECTION   = (byte)0x08;
 	public static final byte RECENTER    = (byte)0x10;
-	public static final byte EXPANSION_1 = (byte)0x20;
-	public static final byte EXPANSION_2 = (byte)0x20;
-	public static final byte EXPANSION_3 = (byte)0x20;
+	public static final byte ROTATE_90   = (byte)0x20;
+	public static final byte EXPANSION_2 = (byte)0x40;
+	public static final byte EXPANSION_3 = (byte)0x80;
 }

src/ve/ucv/ciens/ccg/nxtarbot/threads/MotorControlThread.java

@@ -18,29 +18,19 @@ package ve.ucv.ciens.ccg.nxtarbot.threads;
 import java.io.DataInputStream;
 import java.io.IOException;
 
-import lejos.nxt.BasicMotorPort;
-import lejos.nxt.Battery;
 import lejos.nxt.Motor;
-import ve.ucv.ciens.ccg.nxtarbot.protocol.MotorMasks;
+import ve.ucv.ciens.icaro.libnxtarcontrol.DecodedControlAction;
+import ve.ucv.ciens.icaro.libnxtarcontrol.NxtARControlProtocol;
+import ve.ucv.ciens.icaro.libnxtarcontrol.UserActionListener;
 
 /**
- * <p>Class to control the motors on the robot based on isntructions received via
+ * <p>Class to control the motors on the robot based on instructions received via
  * Bluetooth.</p>
- * 
- * <p>The instructions are codified on a very simple protocol:<p>
- * <ul>
- *     <li> Every protocol packet is exactly two bytes long.</li>
- *     <li> The lowest order byte codifies the motor to control and the rotation
- *          direction of the same on it's highest four bits. The lower four bits
- *          indicate that the central motor should return to it's position of
- *          origin. This four bits can also be used for future expansions.
- *     <li> The highest order byte, a number between 0 and 100, contains the
- *          power to send to the motor.</li> 
- * </ul>
  */
-public class MotorControlThread extends Thread{
+public class MotorControlThread extends Thread implements UserActionListener{
 	private boolean done;
-	private DataInputStream inputStream;
+	private final DataInputStream inputStream;
+	private final NxtARControlProtocol controlProtocol;
 
 	/**
 	 * Create a new MotorControlThread.
@@ -48,83 +38,59 @@ public class MotorControlThread extends Thread{
 	 * @param inputStream The stream to receive motor commands from.
 	 * @throws NullPointerException If inputStream is null.
 	 */
-	public MotorControlThread(DataInputStream inputStream) throws NullPointerException{
+	public MotorControlThread(final DataInputStream inputStream) throws NullPointerException{
 		if(inputStream == null)
 			throw new NullPointerException("Input stream is null.");
 
-		done = false;
+		this.done = false;
 		this.inputStream = inputStream;
+		this.controlProtocol = new NxtARControlProtocol(this.inputStream);
+		this.controlProtocol.registerUserActionListener(this);
 	}
 
 	/**
 	 * <p>Marks this thread as ready to finish cleanly.</p>
 	 */
 	public void finish(){
-		done = true;
+		this.done = true;
+		this.controlProtocol.removeUserActionListener(this);
 	}
 
 	/**
-	 * <p>Receive and process motor control instructions via Bluetooth.</p>
+	 * <p>Receive and process motor control instructions using the protocol library.</p>
 	 */
 	@Override
 	public void run(){
-		boolean motorA, motorB, motorC, recenterMotorB;
-		int direction, rotation, tacho;
-		byte[] message = new byte[2];
-
 		while(!done){
 			try{
-				// Read the two bytes indicated by the protocol.
-				message[0] = inputStream.readByte();
-				message[1] = inputStream.readByte();
-
-				// Decode the instruction parameters.
-				recenterMotorB = (message[0] & MotorMasks.RECENTER) > 0 ? true : false;
-				motorA = (message[0] & MotorMasks.MOTOR_A) > 0 ? true : false;
-				motorB = (message[0] & MotorMasks.MOTOR_B) > 0 ? true : false;
-				motorC = (message[0] & MotorMasks.MOTOR_C) > 0 ? true : false;
-				direction = (message[0] & MotorMasks.DIRECTION) > 0 ? BasicMotorPort.FORWARD : BasicMotorPort.BACKWARD;
-
-				if(motorA){
-					// Set motor A to run at specified speed.
-					Motor.A.setSpeed(message[1] * Battery.getVoltage());
-					if(direction == BasicMotorPort.FORWARD)
-						Motor.A.forward();
-					else if(direction == BasicMotorPort.BACKWARD)
-						Motor.A.backward();
-				}
-
-				if(motorB){
-					// Set motor B to run at specified speed.
-					Motor.B.setSpeed(message[1] * Battery.getVoltage());
-					if(direction == BasicMotorPort.FORWARD)
-						Motor.B.forward();
-					else if(direction == BasicMotorPort.BACKWARD)
-						Motor.B.backward();
-				}
-
-				if(motorC){
-					// Set motor C to run at specified speed.
-					Motor.C.setSpeed(message[1] * Battery.getVoltage());
-					if(direction == BasicMotorPort.FORWARD)
-						Motor.C.forward();
-					else if(direction == BasicMotorPort.BACKWARD)
-						Motor.C.backward();
-				}
-
-				if(recenterMotorB){
-					System.out.println("RECENTER");
-					// Return motor B to it's origin.
-					Motor.B.setSpeed(50 * Battery.getVoltage());
-					tacho = Motor.B.getTachoCount() % 360;
-					rotation = -(tacho);
-					Motor.B.rotate(rotation, false);
-				}
-
+				controlProtocol.readAndExecuteMessage();
 			}catch(IOException io){
-				// On disconnection terminate.
+				// On disconnection, terminate.
 				done = true;
 			}
 		}
 	}
+
+	@Override
+	public void onListenerRegistered() {
+		System.out.println("Registered.");
+	}
+
+	@Override
+	public void onUserAction1(DecodedControlAction.Motor motorFlag, int speed) {
+		// Rotate 90 degrees.
+		System.out.println("USER_1 :: ROTATE 90");
+		Motor.B.rotate(-120, false);
+	}
+
+	@Override
+	public void onUserAction2(DecodedControlAction.Motor motorFlag, int speed) { }
+
+	@Override
+	public void onUserAction3(DecodedControlAction.Motor motorFlag, int speed) { }
+
+	@Override
+	public void onListenerRemoved() {
+		System.out.println("Remove.");
+	}
 }